Shawn, Thanks. I applied fixes for all of your suggestions. A new webrev is here:
http://cr.opensolaris.org/~tmueller/ips-setup2/ The only remaining pylint output for setup.py are messages regarding the two many public methods and for defining an attribute outside of __init__. I don't think anything can be done about these as they are result of extending the distutils classes. Tom Shawn Walker wrote: > 2008/6/11 Tom Mueller (pkg-discuss) <[EMAIL PROTECTED]>: > >> Please review these changes for transforming the build environment according >> to the message that was sent to the alias last week: >> http://mail.opensolaris.org/pipermail/pkg-discuss/2008-June/003779.html >> > > http://cr.opensolaris.org/~tmueller/cr-setup/src/setup.py.wdiff.html > ========== > > This file needs to be run through pylint; there are various minor > formatting things that need to be fixed. > > Brief examples: > > 127 + "sunos" : scripts_sunos, > > Remove space before ':'. > > 273 + dir_util.mkpath(dst_dir, > verbose=True) > > No space before and after '=' operator. > > There are many other places. > > ---------- > > If you run make clobber and the CherryPy-3.0.3.tar.gz doesn't exist, > it will fail trying to remove it: > > deleting cherrypy > error: CherryPy-3.0.3.tar.gz: No such file or directory > > 306 os.unlink(CPARC) > > This should be wrapped with: > > if os.path.exists(CPARC): > > ------ > > If the download fails, the developer is going to be left with a not > immediately obvious traceback: > > 289 if not os.path.exists(CPDIR): > 290 print "unpacking CherryPy" > > This needs to be another check after the download with something like: > > if not os.path.exists(CPARC): > print "Unable to retrieve %s.\nPlease retrieve the file and > place it at:\n" % (CPURL, CPARC) > > I had this message before because I assumed that someone might be > attempting to build and install this on a system without outside > network access. > > -------- > > Otherwise, I applied your patch and everything seemed to work as expected. > > I did get tripped up a bit when I typed make proto and nothing happened :-) > > Cheers, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
