2008/6/17 Tom Mueller <[EMAIL PROTECTED]>:
> Both comments addressed.
>
> How are you running pylint?
>
> I was using the "python setup.py lint" command, and it sets the maximum line
> length to 90 in the tests/pylintrc file. It also didn't generate the indent
> error (not sure why).
Interesting.
The default pylint setting is for a max line length of 80 characters.
I didn't know that our preferred max line length was 90 as I've had
code review comments come back about lines over 80 characters.
I've been running pylint manually instead of using the "setup.py lint"
command as I didn't realise that was there either.
I've searched the list a few times and looked around our pages trying
to figure out our exact code style specifics, but haven't found much
information.
As for the indentation, I believe I've been using --indent-string="
" in addition to the defaults for pylint.
Speaking of indentation, these should be indented by only four spaces
from the previous line since they are continuations:
http://cr.opensolaris.org/~tmueller/ips-setup2/src/setup.py.html
198 ["%s%s" % ("-I", k) for k in
include_dirs] + \
199 ['-I' +
self.escape(get_python_inc())] + \
200 arch_srcs
202 ["%s%s" % ("-I", k) for k in
include_dirs] + \
203 ['-I' + self.escape(get_python_inc())] + \
204 ["%s%s" % ("-l", k) for k in
elf_libraries] + \
205 elf_srcs
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
