On Tue 22 Jul 2008 at 05:14PM, Shawn Walker wrote:
> Shawn Walker wrote:
> > The following webrev includes proposed fixes for the following bugs:
> >
> > 2239 repository attribute system needed
> > 2603 hgignore needs to be updated for package gui
> 2622
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-2239-2/
>
> Changes from last webrev:
> * Changed to more closely mirror imageconfig by treating configuration
> as a cache (naming convention change)
> * Added doc/repository.txt documenting the new attributes and their purpose.
> * Added tests for boolean attribute data type
> * Fixed boolean attribute validation and set behaviour
> * Fixed bugs in depot test directory handling (see bug 2622 for details)
>
> diff from last webrev:
> http://cr.opensolaris.org/~swalker/pkg-2239-2/raw_files/pkg-2239-2.patch
Shawn-- If I understand the code properly, it seems like you are
establishing a "repository id":
29 repository/ Property group of type "application"
30 /id A Universally Unique Identifier (UUID) used to
31 permanently, uniquely identify the repository.
Now, I get what this is for in the short term, I think-- to generate a UUID for
the feed.
But perhaps calling this the "id" for the whole repository is premature.
In our forthcoming world, it seems like we have:
--Authority (needs an auth-wide UUID?)-------------------------
| |
| Master Depot Mirror Depot Mirror Depot |
| /\ /\ /\ |
| / \ / \ / \ |
| /....\ /....\ /....\ |
| |
---------------------------------------------------------------
Where the triangles represent load balancers. So it seems like what
you're calling the "id" is really just one ID among several.
For example:
- We might want a UUID which is authority wide someday.
- We might want a UUID per master/mirror instance
- We might want a UUID per sub-depot (the thing behind the
load balancer) for diagnosability/debuggability.
So, I was wondering if the ID you are adding is more properly called a
"feed_id"? Or is it a UUID which uniquely identifies this set of
repo contents (in which case, "contents_id"?)
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
