On Fri, Aug 01, 2008 at 02:32:20AM -0700, Dan Price wrote: > > Hi folks, > > Please review my fixes for: > > 2418 'pkg version', 'pkg image-update' should error on additional arguments > 2624 'pkg contents -r somethingnonexistent' traces back > 2658 image-update should check for latest SUNWipkg, point to release notes > > http://cr.opensolaris.org/~dp/ips-warning/ > > Thanks for your prompt review. This needs to go in asap. > > Please note that I'm still trying to work out what the test cases > for 2658 need to look like. It's conceivable that I may need to > defer those until next week but I hope to get them into shape > today. > > I have tested both on live and alt-be images, and with and without > SUNWipkg present in the target image. This fix activates > only when it believe it is treating an opensolaris distro image, so > the test suite passes with no changes. The bug report contains > a rundown of the behavior with the fix in place.
So it looks good to me. One minor thing I saw: http://cr.opensolaris.org/~dp/ips-warning/src/client.py.wdiff.html 1338 + if pargs: 1339 + usage(_("version: command does not take operands ('%s')") % 1340 + " ".join(pargs)) 1341 + I think that should be "catalog-refresh" instead of "verison" since it's in the catalog_refresh function? Thanks, Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
