On Mon, Aug 25, 2008 at 08:22:10PM -0700, Brock Pytlik wrote: > Here's the CR: > http://cr.opensolaris.org/~bpytlik/ips-bug-2989-v1/ > > and the bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=2989 > > The idea is that if indexing fails for any reason during install, > image-update, or uninstall, we attempt to reindex from scratch. This > will at least hide the KeyErrors and other issues from the users until > we can fix the root cause of those problems.
Looks good to me. Only one comment: client.py: 567 - 703 - Maybe just return 1 or 0 and get rid of the fixed/err variables.. They don't make it clearer (to me at least). -Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
