Shawn Walker wrote:
Brock Pytlik wrote:
Here's the CR:
http://cr.opensolaris.org/~bpytlik/ips-bug-2989-v1/
and the bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=2989
The idea is that if indexing fails for any reason during install,
image-update, or uninstall, we attempt to reindex from scratch. This
will at least hide the KeyErrors and other issues from the users until
we can fix the root cause of those problems.
client.py:
line 140: you added space to the end of the line here
lines 575-586: As I understand the localization process, you can't
take one localized and blindly append it to another localized string
(mid-sentence, especially) and get a reliable result due to
subject-verb-order, etc. I'd recommend either passing the full string
for each case to _() or dynamically constructing the strong *first*
before passing it to _() at line 586.
I also wonder what impact this will have on the GUI, etc. Should the
re-index logic you added to client.py be a shared method in one of the
search modules that can be called by the GUI or client.py as needed
instead of solely being in client.py?
That would certainly help us. We got hit with a stopper bug for BTS
because we hadn't picked up indexing code changes in duplicated code and
brought them into the GUI. Of course we really want to get rid of the
duplicated code asap so a shared Client API is the way to go for both
pkg(1) and IPS GUI.
JR
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
