Brock Pytlik wrote:
> Out for review again.
> The CR's at:
> http://cr.opensolaris.org/~bpytlik/ips-2989-v2/
> 
> One note, the additions to uninstall in client.py merely match the same 
> error handling that's happening in install and image-update. I must have 
> forgotten to add it to uninstall when I put them in previously.

This looks fine, although I might add that 
"ProblematicPermissionsIndexException" is a mouthful.

Isn't problematic redundant since it's an exception? :-)

Perhaps, "IndexPermissionsException" or "PermissionsIndexException" ?

Cheers,
-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to