Shawn Walker wrote:
line 96: why doesn't clear() clear the image dir? Is this to allow
multiple operations on a single image to happen? What happens if a
process has multiple image objects, and it flips back and forth
between operations on them?
history.py
The client needs to call set_imgdir any time it changes image
directory context. As far as I'm aware, both of our clients are
limited to a single image for a given session. So, I didn't think it
was a problem for now. Once we have a client API, this can be
centralised so it shouldn't be an issue long-term either.
The more I think about it, it seems that the history should be an
attribute of the Image object, especially since the history is stored
within the Image meta data. There is no need for Image to be an object
if history is not. This seems to break the object-oriented design of the
rest of the system.
I did check on the updatetool GUI and it too does not create multiple
Image objects and keep them around. However, since it is oriented
towards managing user images, it does present the user with multiple
images, and a very natural implementation would seem to be to create
multiple Image objects and keep them around for the life of the session.
Tom
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;SWI Install/Update Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
