[snip] >>> - line 349: what should happen if the parse fails? Perhaps simply dump >>> out the raw document? >>> >> I wasn't sure what to do here, so I was just going to let whatever >> exception happened bubble up. I could raise a general exception here with >> something like, "Unable to parse history data: %s" % raw_document? >> > > I don't know that raising an exception is all that necessary in this case, > but the message is fine (I'd put a newline before the document). > > Please don't print a message from inside the history module, or if you do, know that the code will likely have to be changed anyway once the API goes in. At least until we have a general messaging object that works across both the CLI and the GUI, printing a msg isn't friendly. Also, if you're going to raise an exception, please don't make it a RuntimeException. I suspect most (if not all) of those are going to have to be removed from the code eventually.
Brock > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
