* Shawn Walker <[EMAIL PROTECTED]> [2008-09-07 23:46]: A history should be an object. (I can say this, just based on how different history.py looks from everything else.)
> Sample history output (sorted based on mtime of each history entry file): > > Short format: > http://cr.opensolaris.org/~swalker/pkg-1449/short.txt > > Long format: > http://cr.opensolaris.org/~swalker/pkg-1449/long.txt Why is the seventh operation's "Successful" field false? If it's supposed to be the exit status, why call it "successful"? (Is there a reason to have a boolean here, rather than an outcome field, with some set of known outcomes?) > Notes > ===== > * The command column doesn't show the operation performed in the short > format, which means that command is of limited value when the gui has > performed an operation. I've thought of adding the "operation" column > to the short format to work around this limitation. Agree. In fact, I'd rather see operation, client, and outcome than the full command line. > * There is currently no limit on the amount of history entries. > Eventually, we could implement a policy that limited the history based > on a certain number of entries as an image attribute. I didn't want to > bite off any more than this for the initial implementation. Thus, I > have filed bug 3304 for that. Sounds reasonable. We'll need a truncate operation of some kind. > Change Summary > ============== > * Implemented new history module to support the storage information > related to operations that modify an image and to support better > post-mortem analysis. > > * Stores each history entry in an XML file in the new /history directory > under image.imgdir. Umm. I didn't expect XML to sneak in here; if it must, where's the DTD? > * History entry files are named after the pattern: > %Y%m%dT%H%M%SZ-{random_sequence}.xml I think people will want to query on time ranges and on package histories (how did I get SUNWjdmo??)--so we'd better have a bug to track those. Looking pretty sound otherwise. - Stephen -- [EMAIL PROTECTED] http://blogs.sun.com/sch/ _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
