Michal Pryc wrote: > Hello, > I have made some changes to support BE Management: > http://defect.opensolaris.org/bz/show_bug.cgi?id=3201 > > The webrev is at: > http://cr.opensolaris.org/~migi/10_09_be_management_3201_v1/ > I know the interface to libbe has changed (or changes in 97). Please take a look at the change Tim Knitter put back (501:9467b61d5b40) and do something similar every place you use be.beList. We need this to be compatible both with the new code and the old code so we can continue to back-publish.
beadm.py line 163 is where be.beList is being used. It's also probably worth your time to talk to the people writing libbe to find what changes they might have planned for their API, or to at least let them know that you're directly dependent on them. Ethan Quach is the person who've I've talked with about libbe before. beadm.py: You might consider using our misc.py bytes_to_str method instead of rolling your own in __convert_size_of_be_to_string(self, be_size). I'm guessing that what we have should be sufficient, or can be made to do what you need it to do. > I have made some tests and it looks like everying works fine :) > > Some screenshots from the BE Management: > http://cr.opensolaris.org/~migi/be_admin_screenshots_v0/ > > be_admin0.png: Menu entry > > Could you add a horizontal separator between the BE selection and Quit? Assuming that eventually more things will live in this menu, I think it makes for clearer organization. Also, for those of us who are clumsy, having more space between things like Quit and everything else is always a plus. > be_admin1.png: BE management just after start. The OK and Cancel buttons > are active all the time. Reset is active only when the user made some > changes. > Nits: I might make it "Currently Active Boot Environment" rather than Boot Environment currently Active. Should it be "Set the Active BE for next reboot" rather than "Set Active BE for next reboot"? > be_admin2.png: Only the "Active on Reboot" BE was changed and OK was > pressed by the user - the confirmation dialog. > I'm unclear why you'd show the top box (Boot Environments to be deleted:) when none are going to be. If it's simply ease of implementation, that's fine because that can be changed later. If this is a design decision, I'd like to understand more about it. I like the interface you've put together. Brock > be_admin3.png: Only one BE was selected to be removed and user clicked > OK button - the confirmation dialog. > > be_admin4.png: 3 BE were selected to be deleted and the "Active on > Reboot" BE was changed. User pressed OK - the confirmation dialog. > > be_admin5.png: User selected some BE to be deleted or activated, pressed > OK and then in the confirmation dialog pressed OK again. > > be_admin7.png: Some error occured (for example user didn't have > permissions to remove BE, or other error...). The error dialog popups. > When the user clicks Close button, the default BE management is still > there, but the list is updated reflecting about the current status. So > for example the Active on Reboot BE was changed but somehow we couldn't > delete 2 of 4 selected BE's then the list will show changed Active on > Reboot BE and also will not contain the 2 BE's which were removed. > > be_admin8.png: If user selects some BE to be removed, those BE can not > be selected to be Activated. If some BE are selected to be Active on > Reboot then this BE can not be deleted. The Active BE from the initial > state (opensolaris-3) can not be deleted at all. > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
