Michal Pryc wrote: > Brock Pytlik wrote: >> Michal Pryc wrote: >>> Hello, >>> I have made some changes to support BE Management: >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3201 >>> >>> The webrev is at: >>> http://cr.opensolaris.org/~migi/10_09_be_management_3201_v1/ >> I know the interface to libbe has changed (or changes in 97). Please >> take a look at the change Tim Knitter put back (501:9467b61d5b40) and do >> something similar every place you use be.beList. We need this to be >> compatible both with the new code and the old code so we can continue to >> back-publish. >> >> beadm.py line 163 is where be.beList is being used. >> >> It's also probably worth your time to talk to the people writing libbe >> to find what changes they might have planned for their API, or to at >> least let them know that you're directly dependent on them. Ethan Quach >> is the person who've I've talked with about libbe before. >> >> beadm.py: You might consider using our misc.py bytes_to_str method >> instead of rolling your own in __convert_size_of_be_to_string(self, >> be_size). I'm guessing that what we have should be sufficient, or can be >> made to do what you need it to do. > > Good to know. I didn't wanted to depend on more code from IPS, since > this would introduce risk if the misc.py bytes_to_str would be changed > or renamed. What do you think?
If it gets renamed by us, it's our responsibility to fix it. If it gets changed, that's on purpose. Either way, using that function will be good since it will ensure that the gui and cli represent sizes of "things" the same way. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
