Danek Duvall wrote: > On Tue, Sep 23, 2008 at 03:36:51PM -0700, Brad Hall wrote: > >> http://cr.opensolaris.org/~bhall/bug-388-2/ > > client.py: > > - line 324: no need for pkgerr; you can just test failed_actions. > > pkg.1.txt: > > - You no longer implement -n, so it should get removed from the docs. > > pkgplan.py: > > - line 120: If I'm reading this correctly, you're only going to be fixing > hardlinks that are in this package, rather than in any package on the > system. > > - line 127: why cmp() instead of ==? > > file.py: > > - line 53: I didn't respond to your question about my comment on this > before, but the problem is that this flag, as a class variable, is set > to be the same for each instance of the class. So if you have a > hundred file actions which simply need their modes changed, and one > which needs to be downloaded again, they'll all be downloaded again. > > hardlink.py: > > - line 101: I think the comma there needs to be a percent. > > - line 104: if either the path or the target doesn't exist, then the test > here will throw an exception. Like you did in the file action, you > probably should return before this if there've been any errors. > > - line 109: Typo in "unexpected". > > Bart also reminded me yesterday that you'll need to do the same thing with > directories as upgrade does -- if a directory gets "fixed" back into a > file, and has any contents, the directory will need to be salvaged. >
The easiest way to implement the directory code and make hardlinks work correctly is to use imageplan.evaluate and imageplan.execute. Once you have your pkgplans, you'll want to start executing at self.state = EVALUATED_PKGS in imageplan.evalute. - Bart This will also insure that any actuators get re-run... - Bart -- Bart Smaalders Solaris Kernel Performance [EMAIL PROTECTED] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
