On Mon, Nov 24, 2008 at 10:58:45AM -0800, Brock Pytlik wrote:

> http://cr.opensolaris.org/~bpytlik/ips-2701-v3/

pkg.depotd.1m.txt:

  - line 128: I'd say "path" instead of "writ_root".  This should also be
    writeable-root.

config.py:

  - "writable" should be "writeable".  Same in pkg-server.xml.  Maybe other
    places too -- grep for it.

svc-pkg-depot:

  - line 114: $? is now giving the return value of the second svcprop
    command instead of the first -- is that what's intended?  You should
    probably update the comment to reflect the interaction between readonly
    and writeable-root.  Though honestly, it's not clear to me why having a
    writeable root would turn fork/exec back on again -- isn't the point of
    that to lock readonly servers down tight?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to