Hi Shawn,
The code looks fine. I just have a nit for the grammar in the error
message on line 43 of face.py. It's currently written as, "mako
templates is required to use this program." There's singular/plural
disagreement here. I'd change it to something like:
Mako templates are required to use this program
or
The mako template module is required in order to use this
program.
Thanks,
-j
On Wed, Nov 26, 2008 at 05:43:11PM -0600, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains fixes for the following issues:
>
> 5466 depot should give a clear failure message if unable to import
> mako templates
>
> This changes the depot to fail with the following message if it is
> unable to import the mako templates module:
>
> "mako templates is required to use this program."
>
> This change is just to make things friendlier for those building the
> gate manually or for those on other platforms not relying on our packages.
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-5466/
>
> Cheers,
> --
> Shawn Walker
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
