Shawn Walker wrote:
> Brock Pytlik wrote:
>> Shawn Walker wrote:
>>> [EMAIL PROTECTED] wrote:
>>>  
>>>> Hi Shawn,
>>>> The code looks fine.  I just have a nit for the grammar in the error
>>>> message on line 43 of face.py.  It's currently written as, "mako
>>>> templates is required to use this program."  There's singular/plural
>>>> disagreement here.  I'd change it to something like:
>>>>
>>>>     Mako templates are required to use this program
>>>>
>>>> or
>>>>
>>>>     The mako template module is required in order to use this
>>>>     program.
>>>>     
>>> Actually, the name of their project is "Mako Templates for Python" so 
>>> I intentionally said requires "mako templates".  So, changing it to 
>>> "are required" wouldn't be right...
>>>
>>>   
>> Then how about "The Mako Templates project" or j's second option. I 
>> agree that even if the first is technically correct, it will sound 
>> awkward to the average user.
> 
> What about:
> 
> Mako Templates for Python is required to use this program.

I've opted to change this to:

"Mako 0.2.2 or greater is required to use this program."

Does that satisfy everyone?

The only sad thing is that the version isn't exposed so I can't verify 
which version they're using.

-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to