On Mon, Dec 01, 2008 at 10:14:58AM -0800, [EMAIL PROTECTED] wrote: > Folks, > I have a small code review for bug 5519. It was reported earlier this > morning. Routines that retry on download need to catch another type of > HTTPError. This is a total of 10 lines of change. > > http://cr.opensolaris.org/~johansen/webrev-5519/
The changes you've made look fine, but I'd expect the fix to handle the exception in a few other places, too, like the try block on line 361 of filelist.py -- basically, anywhere we make an http connection, which I think boils down to anywhere we call versioned_urlopen(), should be protected. Though I'll note that if I create an image that points at an ssh server, nothing bad happens. Seems like the underlying http code somehow lets this succeed. It's not clear to me why this wouldn't raise a BadStatusLine exception (nor does it when pointed at port 25), but it does when pointed at the portmapper (port 111). Perhaps the latter should be used in the testsuite for this class of bugs? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
