> The changes you've made look fine, but I'd expect the fix to handle the > exception in a few other places, too, like the try block on line 361 of > filelist.py -- basically, anywhere we make an http connection, which I > think boils down to anywhere we call versioned_urlopen(), should be > protected.
Arg. I meant to put that exception handler in the blocks at line 361, not where it presently is. I'll move it. > Though I'll note that if I create an image that points at an ssh server, > nothing bad happens. Seems like the underlying http code somehow lets this > succeed. It's not clear to me why this wouldn't raise a BadStatusLine > exception (nor does it when pointed at port 25), but it does when pointed > at the portmapper (port 111). Perhaps the latter should be used in the > testsuite for this class of bugs? I'm not sure either. Perhaps urllib2 is using a different protocol handler when you're connecting to ports 22 and 25? -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
