Danek Duvall wrote:
> On Mon, Dec 08, 2008 at 09:48:23AM -0800, Rich Burridge wrote:
>
>   
>> 3694 Unable to build slim_import for build 98 by default
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3694
>> http://cr.opensolaris.org/~richb/pkg-3694-v1/
>> http://mail.opensolaris.org/pipermail/pkg-discuss/2008-November/008794.html
>>     
>
> line 127-136: why not refer to CACHED_FILES_BASE here?
>   

I was copying the style used in your ELIDED_FILES_... code here. :-)

> Otherwise, looks fine (assuming that you got the right files in the right
> builds).
>   

I believe so.


>> 4475 importer recipes shouldn't use from ./*
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4475
>> http://cr.opensolaris.org/~richb/pkg-4475-v2/
>> http://mail.opensolaris.org/pipermail/pkg-discuss/2008-November/008791.html
>> (Danek review the first webrev. Second webrev just adjusts files from
>> the latest WOS build).
>>     
>
> This still looks fine.
>   

Okay. I'll check that one in.

Thanks.

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to