Danek Duvall wrote: > On Mon, Dec 08, 2008 at 09:48:23AM -0800, Rich Burridge wrote: > >> 4944 Need a script to check the classifications of the latest packages. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4944 >> http://cr.opensolaris.org/~richb/pkg-4944-v1/ > > line 36: Derive from object, please. > > line 40: Don't include references to bugids.
So changed. > line 76: what's the colon for? Cut and paste error. > Also, please pull the trailing triple-quote > onto this line. > > line 82, 93, 97: drop So changed. > line 107, ff: no need for backslashes inside brackets. Okay. I've also added in the new (and changed) classifications defined in bug #5196: Applications / Panels and Applets Desktop (GNOME) / Theming System / Multimedia Libraries > line 194: drop the spaces around the equals. So changed. > line 235, 236: -p should point to the root of the proto area, not one level > up. > Drop the "/root_i386" bit. Okay. > line 241: why not just set the environment variable with os.putenv()? That's certainly another way of doing it. So changed. > line 248: you can add -H to the commandline options instead Ah. Okay. Adjusted accordingly. > line 256: why use category_found when you can just use category? Good point. Adjusted accordingly. > line 269: probably want to add a "1" argument to split(), too. > > line 273: "not in" preferable So changed. > > line 275: 4-space continuation indent So changed. New webrev at: http://cr.opensolaris.org/~richb/pkg-4944-v2/ Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
