Danek Duvall wrote: >>> line 123: no spaces around equals in argument lists. >>> >> Sorry, not sure I understand. You want: >> >> def usage(self, usage_error = None): >> >> to be: >> >> def usage(self, usage_error=None): >> >> ? >> > > Yes. > > >> Note that I was copying the code in the usage() function in >> .../gate/src/client.py. It's similar in .../gate/src/pull.py. >> > > Yes. I started off by putting spaces around the equals, but after being > beaten over the head with PEP8, decided that we should switch to that for > the standard. We've been slowly removing the spaces as we change the > surrounding code, and making sure that new code follows the standard. >
Okay. So changed in my workspace. >>> Two: this finds all files under the current directory, regardless of >>> what build they belong to, or even whether they're a descriptor file >>> that the importer would ever read! That sounds like it'll lead to a >>> hell of a lot of useless noise. >>> >> Yes, but it doesn't take long and the code catches (and ignores) all the >> files it isn't interested in. >> > > How, exactly? It complains if there isn't a "package" statement in a given > file, but that doesn't help when you're looking at an import file that's > not used for the build you're checking. > Good point. We need to just check the latest set of IPS package files. It should take the same approach as the cleanup_packages() method in list_build_files.py. See lines 134-144 in: http://src.opensolaris.org/source/xref/pkg/gate/src/util/distro-import/list_build_files.py I'll work on a new webrev that does that. Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
