Danek Duvall wrote: > On Thu, Dec 11, 2008 at 02:03:01PM -0800, Rich Burridge wrote: > >> Good point. We need to just check the latest set of IPS package files. >> It should take the same approach as the cleanup_packages() method >> in list_build_files.py. See lines 134-144 in: >> http://src.opensolaris.org/source/xref/pkg/gate/src/util/distro-import/list_build_files.py >> >> I'll work on a new webrev that does that. > > Indeed, why not just use list_build_files.py directly? (Or commonize the > code into a module and import it?)
list_build_files.py wasn't designed to work with a build number of "latest". Though the cleanup_packages() routine is identical in both scripts, the save_entry() routines are slightly different. It's getting close to the point though, where some of these methods/functions could be moved out to a separate Python file which gets imported. For now, I'd prefer to keep each script separate and self-contained. If I do another one, then I'll start to build up a file of common functionality and adjust all the other scripts accordingly. New webrev at: http://cr.opensolaris.org/~richb/pkg-5705-v3/ Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
