Tom Mueller (pkg-discuss) wrote: > Please review these changes for supporting authority enable and disable: > > Webrev: http://cr.opensolaris.org/~tmueller/cr-2340/ > > Issue: http://defect.opensolaris.org/bz/show_bug.cgi?id=2340 > > The design details for this are in the issue. > > Note: I've tested packagemanager on this that when an authority is > disabled via pkg(1), then packagemanager no longer sees it. However, > this changeset doesn't include the changes needed to make packagemanager > be able to edit disabled authority properties for to enable/disable > authorities. Another RFE will be needed for that.
pkg.1.txt: lines 281-285: suggested wording: With -e (--enable), enable the authority; with -d (--disable), disable the authority. A disabled authority is not used when populating the package list, or in certain package operations (install, uninstall, and image-update). However, the properties for a disabled authority can still be set and viewed. If only one authority exists, it cannot be disabled. line 297: s/. With -a, display all authorities /. With -a, display all authorities (/ line 298: s/disabled./disabled)./ client/image.py: lines 1379-180: this comment doesn't make sense given that the disabled status is checked on line 1394 General comments: * I would change ImageConfig() to have an init() parameter for the directory and have it stash it away. It should read() and write() from that so that calls to read() and write() where we use it don't need the directory as an argument. Otherwise, this seems fine. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
