Shawn, Thank you for the comments. The wording you suggested is better; I've updated the file accordingly.
The comment has been removed. I put in the comment before I put in the check and then forgot to remove the comment later. WRT passing the directory to ImageConfig, this would be fine except for one test case in which we create an ImageConfig object, read in the data, and then write out the data to a different directory and test that the written data is the same as what was read in. So to implement this test, we would also need to have a way to copy and ImageConfig object from one to another. Also, the ImageConfig object is created from two places within Image, and it is read/written from two places. So the number of times the directory would need to be references wouldn't change. Tom Shawn Walker wrote: > Tom Mueller (pkg-discuss) wrote: >> Please review these changes for supporting authority enable and disable: >> >> Webrev: http://cr.opensolaris.org/~tmueller/cr-2340/ >> >> Issue: http://defect.opensolaris.org/bz/show_bug.cgi?id=2340 >> >> The design details for this are in the issue. >> >> Note: I've tested packagemanager on this that when an authority is >> disabled via pkg(1), then packagemanager no longer sees it. However, >> this changeset doesn't include the changes needed to make >> packagemanager be able to edit disabled authority properties for to >> enable/disable authorities. Another RFE will be needed for that. > > pkg.1.txt: > lines 281-285: suggested wording: > > With -e (--enable), enable the authority; with -d > (--disable), disable the authority. A disabled authority is not used > when populating the package list, or in certain package operations > (install, uninstall, and image-update). However, the properties for a > disabled authority can still be set and viewed. If only one authority > exists, it cannot be disabled. > > line 297: s/. With -a, display all authorities /. With -a, display > all authorities (/ > line 298: s/disabled./disabled)./ > > client/image.py: > lines 1379-180: this comment doesn't make sense given that the > disabled status is checked on line 1394 > > General comments: > * I would change ImageConfig() to have an init() parameter for the > directory and have it stash it away. It should read() and write() > from that so that calls to read() and write() where we use it don't > need the directory as an argument. > > Otherwise, this seems fine. > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
