On Tue, Jan 06, 2009 at 05:18:01PM -0600, Shawn Walker wrote:

> http://cr.opensolaris.org/~swalker/pkg-2300-6022/

t_pkg_depotd.py:

  - line 313, 315: any reason these aren't done by default in the
    depotcontroller setup?

  - line 323: is this safe?

  - line 374: why start up this depot on a second port, rather than just
    reusing the one already started if with_packages is true?  For that
    matter, why republish six times?

  - line 402: trailing newline

testutils.py:

  - line 488-490: no space around equals

catalog.shtml:

  - line 87: is "catalog" necessary here?  Similarly in search.shtml and
    stats.shtml.  I don't know that exposing the term at such a high level
    is all that useful.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to