Danek Duvall wrote: > On Tue, Jan 06, 2009 at 05:18:01PM -0600, Shawn Walker wrote: > >> http://cr.opensolaris.org/~swalker/pkg-2300-6022/ > > t_pkg_depotd.py: > > - line 313, 315: any reason these aren't done by default in the > depotcontroller setup?
Because these paths are specific to the test suite? Note that it's setting the paths to the prototype area. Maybe I'm missing something. > - line 323: is this safe? Probably not; it was there before though. However, I've changed this to only catch OSError and then raise if the error wasn't EEXIST. > - line 374: why start up this depot on a second port, rather than just > reusing the one already started if with_packages is true? For that Because the one started via with_packages was stopped. The other reason is because I need to test the depot in a specific mode (such as readonly) which means I need to start the depot in publishing mode (separately) first to publish the packages and then restart in a different mode. > matter, why republish six times? Look at the first line underneath for with_packages; I remove the entire depot directory each time, thus the re-publishing is necessary. I remove the directory each time to ensure that a first run of a depot in a given mode works as expected. The goal of the test is to ensure that the pages all work as expected whether the catalog is empty or not in every depot mode. That's why I stop and start the depot server, re-publish every time, etc. As for why I don't group all of the with_packages tests together, that's because it caused sporadic test failures for reasons yet unknown. My guess is some file-locking with search indexing was delaying depot responsiveness causing the depotcontroller to fail. > - line 402: trailing newline Intentional, but removed now. Updated webrev: http://cr.opensolaris.org/~swalker/pkg-2300-6022-2/ diff from last webrev: http://cr.opensolaris.org/~swalker/pkg-2300-6022-2/v1-v2.patch Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
