Danek Duvall wrote: > On Tue, Jan 06, 2009 at 06:57:38PM -0600, Shawn Walker wrote: > >> I'll have to keep the regex matching for the individual components, but >> going back to the split method is doable for getting the components >> themselves. >> >>> Yes. I don't get why this has anything to do with Fmri objects. >> Because you said it should be the same as MatchingPkgFmri, etc.; I took >> your statement literally :) > > Ah. You might find that what you really need is a MatchingDotSequence more > than a MatchingVersion, though. I'm also not sure why you'd need to keep > the regexp way of doing this for the DotSequences -- you could override > dotsequence_int() to do something special with "*". I'm not sure that "?" > as a metacharacter for versions is useful in the way it is for package > names.
Actually, I ended up needing both. Updated webrev: http://cr.opensolaris.org/~swalker/pkg-5999-6010-2/ diff from last webrev: http://cr.opensolaris.org/~swalker/pkg-5999-6010-2/v1-v2.patch Notes: I'm somewhat iffy on the MatchingDotSequence inheritance and my overrides. See the unit test for expected usage and results. Change Summary: * Added MatchingVersion, MatchingDotSequence classes. * Fixed a bug causing matches to be returned more than once. * Improved extract_matching_fmris() performance relative to last version. * Expanded unit test. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
