[email protected] wrote: >>> * Added MatchingVersion, MatchingDotSequence classes. > > In the comparison methods for these classes you correctly check to see > if other is None. There's a case that you're not catching, though. > I've run across this in other places in the code: you end up performing > a comparison on two objects that aren't of the same class. If you think > it's possible that you might be comparing different object types, insert > an isinstance() check at the beginning of the comparison routine. As an > example, a lot of the exception classes in misc.py implement such a > check.
They're intended to compare different object types, although they're only intended to compare Version and MatchingVersion objects; not any other type. I can add a check for that though. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
