> > Thanks for all of the reviews, but I jumped the gun. The first fix > > didn't pass the test suite. I've re-whacked this so it works correctly. > > The new fix is equally concise, but actually passes the test suite. > > I updated the webrev in place this time, since the whole thing is so > > small. > > Seems fine, although I wonder why origin_changed is True for a disabled > authority...
We only really care once the authority has been enabled. However, the test suite depends upon packages from disabled authorties being removed from the test suite. The code that deals with deleting catalogs, the catalog cache, and the subsequent refresh only needs to get run when an origin has changed, or an authority has been enabled/disabled. If you have a suggestion about a better way to write this, I'm all ears. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
