> Thanks for the reminder again.  I like the structure better here, but I'm
> not sure that refresh_allowed should make any difference about whether the
> existing catalog for the authority being disabled should be removed from
> the cache.  Other than that, it looks fine.
> 
> What about
> 
>     if refresh_catalog or purge_catalog:
>         destroy
>         destroy
> 
>         if refresh_catalog and refresh_allowed:
>             retrieve
> 
>         cache
> 
> ?

Intuitively, I agree.  However, we have some assumptions in our test
suite that if an authority is disabled, we remove its catalog entries
unless a refresh is not allowed.  In that case, we leave the catalog in
place until such a time that we can connect to the network and refresh
the catalog.  I wrote a similar version to what's above, but found it
didn't pass test.

The other possibility is to change the test case, if we think it's
incorrect.

-j

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to