I haven't had a chance to look at all the changes in detail, but I'll
try to get to it tomorrow. From a high level perspective though, I have
a concern (and I apologize if this is rehashing old discussions or
beating a dead horse).
From a user's perspective, I think I rarely care which repo a package
comes from. Sure, I want that information available if I ask for it, but
I don't want that to interfere with me finding a package or installing
it. I bring this up now b/c I think this changeset takes us farther away
from that perspective. If I've understood this set correctly, it's
further separating the repo information which may make it harder to
implement a unified view in the future.
Maybe that ship has sailed, but I'm hoping it hasn't.
Brock
Michal Pryc wrote:
Hello,
The webrev is:
http://cr.opensolaris.org/~migi/lists_split_10_02_2009_v1
This change makes the per repository underlying data model allowing
selecting packages in many of them at the same time.
Before the change, the main data model contaied all packages and it's
selections. Current implementation splits that, so the selections
are stored in dictionaries and data model is per repository only
stored in the gtk.ListStore. This improves performance of many functions,
as we are working on smaller data sets and we are not iterating
through all packages to get selections.
Switching repositories may take now more time, but this will be
improved a lot once caching will go in, but I didn't wanted to introduce
to many changes in one webrev.
This fixes bugs:
[Split the repository data models]:
http://defect.opensolaris.org/bz/show_bug.cgi?id=6516
[Package manager should elide categories which are empty]
http://defect.opensolaris.org/bz/show_bug.cgi?id=5662
[packagemanager chews CPU when changing repository]
http://defect.opensolaris.org/bz/show_bug.cgi?id=6227
[Unnecessary processing during PackageManager startup]
http://defect.opensolaris.org/bz/show_bug.cgi?id=5866
[Two entries appear in packagemanager for installed package]
From the bug description I think I was not able to reproduce, but I
didn't understand
this bug description in 100%.
http://defect.opensolaris.org/bz/show_bug.cgi?id=6226
["find as you type" performance doesn't scale]
This is just an improvement for this bug. Having per repository data
model refilter function will reduce
time to perform it, but only in some cases. Please read more in the
bug description.
http://defect.opensolaris.org/bz/show_bug.cgi?id=6365
*
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
