Shawn,
So it looks like the GUI code is complete as send in the previous webrev.
I am not sure how to co-ordinate this as we do have three parts of this
change to go in:
- your api change
- BE management change
- gui change for your api
The last two are needed to go together as they are using the same
glade file. Of course we could put it separate, but I believe there
isn't such need. What I am proposing, when everything will be reviewed:
First put the BE management change together with the glade file for
the webinstall. Having this will not break anything, we will just have
webinstall dialogs in the gladefile.
- Once reviewed both api and gui put back the api changes
- Put back the gui changes without glade file
This will give us separation in the hg revisions and because of that we
will have nice history to go back when needed.
When do you expect to put your api's in the gate?
best
Michal
Shawn Walker wrote:
Michal Pryc wrote:
Shawn,
I got it working, but there are few bugs and limitations:
* If the p5i do not contain repository information we are skipping
this p5i file and do nothing as the publisher returned from the api is
None for such situation. So it would be hard to tell from which
publisher this package comes from, eg.
---------------------
{
"packages": [
"pkg:/[email protected],5.11-0",
"baz"
],
}
---------------------
It's fine if you skip it for now, but it was intentional that you don't
know which publisher they came from. It's just a list of packages to
install.
* The p5i file can't contain alias information or we will get exception:
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python2.4/threading.py", line 442, in __bootstrap
self.run()
File "/usr/lib/python2.4/threading.py", line 422, in run
self.__target(*self.__args, **self.__kwargs)
File "/usr/lib/python2.4/vendor-packages/pkg/gui/repository.py",
line 879, in __add_repository
self.api_o.add_publisher(pub)
File "/usr/lib/python2.4/vendor-packages/pkg/client/api.py", line
861, in add_publisher
self.img.add_publisher(pub, refresh_allowed=refresh_allowed)
File "/usr/lib/python2.4/vendor-packages/pkg/client/image.py", line
743, in add_publisher
if pub == p or (pub.alias and pub.alias == p.alias):
AttributeError: 'str' object has no attribute 'alias'
That's a bug; I've added a test case for this and fixed it.
Thanks,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
