Shawn - when Michal gets these bugs sorted along with the performance
issue, could you sign up to do a review of the code tomorrow your time
(end of business our time), so we'd have a chance of getting the putback
done on Monday. If you are updating your webrev based on J's comments we
also might have some refactoring to do and that could also be done
tomorrow by Michal if you spin another webrev today.
Thanks,
JR
Shawn Walker wrote:
Michal Pryc wrote:
Hello,
I have merged all the gui changes together and posted at:
http://cr.opensolaris.org/~migi/webinstall_v1/
This patch should be applied on top of the:
http://cr.opensolaris.org/~swalker/pkg-5871
(note this webrev is missing filelist.py)
I've found a few bugs when testing this patch applied as described above:
======================================================================
core dump
======================================================================
-- start packagemanager
-- go to file -> manage repositories
-- ensure that there are two repositories listed (i haven't tested
with more than that, results may vary)
-- using keyboard, navigate to repository list (tab key) and highlight
first entry
-- using keyboard, go to second repository entry (down arrow)
-- using keyboard, trigger modify dialog (Alt + M)
-- using keyboard, close modify dialog (Escape)
-- using keyboard, trigger modify dialog (Alt + M)
-- core dump [1]
======================================================================
weird dialog window / error
======================================================================
-- start packagemanager
-- go to file -> manage repositories
-- ensure that there are two repositories listed (i haven't tested
with more than that, results may vary)
-- using keyboard, navigate to repository list (tab key) and highlight
first entry
-- using keyboard, trigger modify dialog (Alt + M)
-- using keyboard, close modify dialog (Escape)
-- using keyboard, trigger modify dialog (Alt + M)
-- tiny dialog window comes up and following error is printed in console:
/export/home/xxx/devel/pkg-5871-gui/proto/root_i386/usr/lib/python2.4/vendor-packages/pkg/gui/repository.py:753:
GtkWarning: file gtkcontainer.c: line 1476: assertion
`GTK_IS_CONTAINER (container)' failed
self.w_repositorymodify_dialog.show_all()
======================================================================
user image created with --no-refresh causes startup error:
======================================================================
-- pkg image-create --no-refresh -a test=http://ipkg.sfbay/dev /tmp/image
-- pfexec python packagemanager.py -R /tmp/image
-- received this dialog box message:
Error occured while getting list of packages
-- received this message in console output:
Traceback (most recent call last):
File "packagemanager.py", line 648, in __init_tree_views
row = section_list[self.initial_section]
IndexError: could not find tree path
-- when attempting to close the packagemanager, it never closed and
printed this message:
Traceback (most recent call last):
File "packagemanager.py", line 1004, in __on_mainwindow_delete_event
if self.__check_if_something_was_changed() == True:
File "packagemanager.py", line 1578, in
__check_if_something_was_changed
for pkg in self.application_list:
TypeError: iteration over non-sequence
======================================================================
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
