Shawn Walker wrote:
Brock Pytlik wrote:
Shawn Walker wrote:
line 788: curious, is there a reason client_update_index can't
perform this automatically if needed?
Nope, there isn't off the top of my head. Would you rather have it in
there?
It just seemed logical so that you a developer doesn't have to
remember to make this check any time client_update_index is called...
The difference is that on a non-empty index, it would open the roughly 6
index files and read their first lines twice instead of once. So, it
probably doesn't make much of a difference, but it is a slight
performance penalty just like the thing you pointed out about having the
boolean logic in the wrong order.
Brock
This changeset could also use some tests to verify that the new
behaviour actually happens as intended.
Ok. I'll assume you mean not rebuilding an index in a non-empty
image, since everything else is being tested already.
Right.
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
