[email protected] wrote:
Webrev reflecting Shawn's comments at:
http://cr.opensolaris.org/~bpytlik/ips-7835-v2/
Need one more set of eyes on it (and an open gate) before it can go back.
Just nits from me.
imageplan.py:
- lines 786-790 This might be easier to read if written as:
if self.is_image_empty():
ind.setup()
ind.client_update_index((self.filters,plan_info), self.image)
elif ind.check_index_existence():
ind.client_update_index((self.filters,plan_info), self.image)
Well, because I know the kinds of mistakes I make, like modifying one
call and not the other, I'm not a fan of this one.
alternatively, you could extract the second empty_image:
if empty_image:
ind.setup()
if empty_image or ind.check_index_existence():
ind.client_update_index((self.filters,plan_info), self.image)
This works for me though :)
server/catalog.py:
- lines 226 & 227: Another possiblility would be to declare cie as
False at the beginning of the function and simply pass in the
execption handler. It took me a minute to realize that the
function, and not just the exception handler, could set this value
to false.
Good idea, I like that better.
-j
Great, then when the gate opens, I think this is ready to go back.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
