Padraig,
This looks fine for me.
Just to note that:
$ pfexec python
>> import os
>> os.path.expanduser('~')
will give us wrong home directory, so parsing /etc/passwd is in that
case fine.
Michal
Padraig O'Briain wrote:
I have prepared another webrev,
http://cr.opensolaris.org/~padraig/ips-7852-v2/.
I think this addresses the concerns raised.
Padraig
On 04/06/09 21:23, John Rice wrote:
Shawn Walker wrote:
jmr wrote:
The correct solution here is to set $HOME to /root for PM which is
running as root. In this way the appropriate dbus session id file is
set up for root and can be shared by all instance of PM running as
root and any other applications running as root that need access to
root's shared dbus session. We should not set $HOME to some other
unique tmp dir as this will mean applications running as root will
not be able to share the same dbus session, which is not the correct
dbus behavior.
I don't agree that this is the solution for a few reasons:
* it assumes that "/root" is root's home, it should be using what's
in passwd
Ok - we can easily check if its been set to something else in root's
passwd entry.
* it assumes that there is such a thing as "root", which may not be
true long-term
That is something we can tackle, when and if that occurs. For now we
have a potentially serious problem with root overwriting user's dbus
session id and we need to fix it. I want this fixed for 2009.06.
JR
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
