Shawn Walker wrote:
jmr wrote:
Shawn Walker wrote:
Padraig O'Briain wrote:
I have prepared another webrev, http://cr.opensolaris.org/~padraig/ips-7852-v2/.

I think this addresses the concerns raised.

Instead of just hardcoding /var/tmp, why not use tempfile.mkdtemp?

Then just make sure that gets removed on exit.
You want this dbus session bus id to be shared by any instances of PM or UM being run by root, so it needs to be located under /var/tmp. If its put under a unique dir for each instance of PM or UM then it can't be shared across the session, which is not the desired behavior.

Okay, but /var/tmp does make it (possibly) specific to OpenSolaris.

That's probably fine, but I thought I'd point it out.

Cheers,
No worries - but as this is targeting OpenSolaris, I'm happy with that choice.

Cheers,

JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to