On Sat, May 02, 2009 at 11:00:27PM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-8487/
api.py:
- line 1238,1239: Since the first value of the return tuple is True iff
the second value is None, then why bother with two return values?
- line 1329: On a related note, bool(origin_changed()) is *always* True,
which is probably not what you want here.
- line 1351: Why add this clause? Isn't it covered by the next one?
image.py:
- in set_attrs(), you delete the line putting newpub into the publishers
array, but I don't see where that's done now; I looked for similar code
in add_publisher(), but don't see it there, either.
- line 688: You might mention that 'pub' overrides 'prefix' if both are
specified.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
