[email protected] wrote:
Hi Shawn,

webrev:
http://cr.opensolaris.org/~swalker/pkg-8487/

Just one issue I found.

api.py:

  - lines 1340: I thought origin_changed was a function, but here you're
    not passing any arguments.

Yep, I fixed that; Danek alerted me.

Here's the final webrev if anyone's interested:
http://cr.opensolaris.org/~swalker/pkg-8487-2/

diff from 1st webrev:
http://cr.opensolaris.org/~swalker/pkg-8487-2/v1-v2.patch

I'll putback later today if there are no further issues raised.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to