I'd like your confirmation that the remote search doesn't run through
server/api.py. From my review of the code, I believe this is true, but
I'd like you to verify that for me.
server/api.py:
204-207: I'd remove these lines and have this raise an exception as
there's no way to test this code right now and it makes understanding
the rest of the code more difficult.
209: I'd put the split inside the if mver: which follows it. Those lines
could also be combined to something like:
if mver:
if mver != version.Version(pfmri.split("@", 1)[1], None):
continue
I'd also like if mver to become if mver is not None, or whatever the
test is actually against.
Other than that, it LGTM,
Brock
Shawn Walker wrote:
Greetings,
The following webrev contains fixes and changes for the following bugs
and RFEs:
2741 advanced web-based package search capability desired
7359 BUI search should allow result type selection
8408 size of input textfields and textareas arbitrarily limited
8530 failed BUI search should be detectable in server logs
8663 bui search should return latest packages only by default
8668 query error causes output validation error in bui
8669 server api changes for version 3 not documented
8670 pkg.server.api search num_to_return, start_point broken
8671 pkg.server.api provides no access to query_string despite
documentation
8672 2009.06 needs to be added to release and branch selection in bui
webrev:
http://cr.opensolaris.org/~swalker/pkg-7359/
Change Summary (high level):
* Search results are now paginated instead of just limiting the user
to an arbitrary 100 results
* Search results now only show the latest versions of packages by default
* A new "advanced search" page has been added with options for:
-- showing results as packages or actions
-- showing all versions (instead of just latest version)
-- performing a case-sensitive search
-- controlling the number of results per page
-- filtering on release and branch (release 0.5.11-build 101, etc.)
* Fixed CSS styles so that search boxes are now proper size (way too
small before -- this was due to a bug in the Yahoo UI CSS I was using)
* added 2009.06 to release and branch labels
Sample:
http://ipkg.sfbay.sun.com:8009/en/index.shtml
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
