Hi all,
(This is for after OpenSolaris 2009.06).
Looking for a code review of the proposed fix for bug #4134:
http://defect.opensolaris.org/bz/show_bug.cgi?id=4134
pkg operations should report operation sizes
Webrev is at:
http://cr.opensolaris.org/~richb/pkg-4134-v1/
The output for install and image-update examples is included below.
Discussion points:
* I'm not intimately familiar with the pkg code, so I suspect
I could be putting this change in the wrong place and/or just
doing it plain wrong. Advice the best approach to fix this would be
very much appreciated.
* The new message (if the user has sub-command options -nv) is:
"Total compressed size: <N.NN> MB"
Is the wording and position/order in the output what is desired?
* Dan, Danek mentioned this morning that you'd been looking at
"beefing up" the install output previously. How do these changes
fit in with what you were thinking?
Thanks.
----
$ pkg install -nv SUNWxsane
Creating Plan \ Before evaluation:
UNEVALUATED:
+pkg:/[email protected],5.11-0.111:20090331T091924Z
After evaluation:
None -> pkg:/[email protected],5.11-0.111:20090331T091924Z
None -> pkg:/[email protected],5.11-0.111:20090331T090534Z
Actuators:
restart_fmri: svc:/application/desktop-cache/gconf-cache:default
None
Total compressed size: 4.40 MB
$
$ pfexec image-update -nv
UNEVALUATED:
+pkg:/[email protected],5.11-0.111:20090418T200225Z
+pkg:/[email protected],5.11-0.111:20090418T200446Z
+pkg:/[email protected],5.11-0.111:20090418T200438Z
+pkg://extra/[email protected],5.11-0.101:20090428T230107Z
+pkg:/[email protected],5.11-0.111:20090418T200317Z
+pkg:/[email protected],5.11-0.111:20090418T200137Z
...
+pkg://extra/virtualbox/[email protected],5.11-0.101:20090428T230152Z
+pkg:/[email protected],5.11-0.111:20090418T200328Z
+pkg:/[email protected],5.11-0.111:20090418T182958Z
+pkg:/[email protected],5.11-0.111:20090418T200006Z
After evaluation:
pkg:/[email protected],5.11-0.110:20090320T185928Z ->
pkg:/[email protected],5.11-0.111:20090418T200225Z
pkg:/[email protected],5.11-0.110:20090320T190157Z ->
pkg:/[email protected],5.11-0.111:20090418T200446Z
pkg:/[email protected],5.11-0.110:20090320T190148Z ->
pkg:/[email protected],5.11-0.111:20090418T200438Z
...
pkg:/[email protected],5.11-0.110:20090320T190217Z ->
pkg:/[email protected],5.11-0.111:20090418T200526Z
pkg:/[email protected],5.11-0.110:20090320T190217Z ->
pkg:/[email protected],5.11-0.111:20090418T200525Z
pkg:/[email protected],5.11-0.110:20090320T181425Z ->
pkg:/[email protected],5.11-0.111:20090418T191354Z
None ->
pkg:/developer/netbeans/plugin/[email protected],5.11-0.111:20090418T200132Z
None -> pkg:/web/[email protected],5.11-0.111:20090418T200522Z
None -> pkg:/[email protected],5.11-0.111:20090418T193131Z
Actuators:
restart_fmri: svc:/system/manifest-import:default
restart_fmri: svc:/application/desktop-cache/gconf-cache:default
restart_fmri: svc:/application/desktop-cache/gconf-cache:default
restart_fmri:
svc:/application/desktop-cache/input-method-cache:default
restart_fmri:
svc:/application/desktop-cache/pixbuf-loaders-installer:default
restart_fmri: svc:/system/manifest-import:default
restart_fmri: svc:/application/desktop-cache/icon-cache:default
restart_fmri: svc:/application/desktop-cache/mime-types-cache:default
restart_fmri: svc:/system/manifest-import:default
restart_fmri: svc:/application/desktop-cache/gconf-cache:default
None
Total compressed size: 1850.54 MB
$
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
