[email protected] wrote:
On Tue, May 12, 2009 at 02:49:27PM -0700, Rich Burridge wrote:
Webrev is at:
http://cr.opensolaris.org/~richb/pkg-4134-v1/
imageplan.py:
- lines 157-163: This is unnecessary. There's a function in pkgpplan
that returns the number of files to be downloaded and the total size
of those files. Check out pkgplan.get_xferstats(). This routine
caches the size value so that multiple passes over the actions don't
occur. In this particular case, you really don't want to look
through the entire manifest, since not all of the actions inside
will be installed. It's also possible that some actions will have a
size but not a csize attribute. In that case, get_xferstats falls
back to using the size instead of the csize. This means that on
line 164, you might want to say something like "Total estimated
size" instead, since we may not always know how much we're
downloading.
Excellent. So changed. New webrev at:
http://cr.opensolaris.org/~richb/pkg-4134-v2/
Thanks!
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
