I have respun the webrev:
http://cr.opensolaris.org/~padraig/ips-8660-v3/
On 06/10/09 19:15, jmr wrote:
Changes look good to me, one nit I'd remove the commented out code in
misc.py at:
72 + #iconview = gtk.IconView()
73 + #icon =
iconview.render_icon(getattr(gtk,
74 + # "STOCK_MISSING_IMAGE"),
75 + # size = gtk.ICON_SIZE_MENU,
76 + # detail = None)
But as part of this webrev also need UM, UMN and Webinstall.py changed
to use os.join.
JR
Danek Duvall wrote:
On Wed, Jun 03, 2009 at 04:10:30PM +0100, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-8660-v1/, fixes
8660 packagemanager traceback if PACKAGE_MANAGER_ROOT missing
trailing '/'
In misc.py, display_help() uses os.path.join() incorrectly -- the
result of
that call will never have application_dir prepended; you'll need to
strip
the leading slash from "/usr/share/..." like you did everywhere else.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
