On Jun 15, 2009, at 8:50 AM, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-5197-v5/, fixes
5197 gui should not manipulate image objects
src/packagemanager.py:
line 3630: did you really want immediate=True here? When is
update_package_list called? Generally, immediate=True should be
reserved for cases where the user has explicitly requested a refresh,
otherwise the API should "do the right thing."
line 3652: while you should arguably be able to get this
information from a single info() call, for now, this would be faster
if you could call this for all of the packages you need to get the
installed version of instead of for each one.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
