I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-5197-v6/, to remove
immediate=True from call to refresh.
The webrev fixes
5197 gui should not manipulate image objects
The webrev contains the following changes:
1) Define error_occurred in misc.py and use in beadmin.py,
repository.py, webinstall.py, packagemanager.py, updatemanager.py
2) Define get_api_object in misc.py and use in webinstall.py,
packagemanager.py, updatemanager.py, updatemanagernotifier.py
3) Call refresh on api object instead of image.load_catalogs in
packagemanager.py
4) Use info call to get installed version in packagemanager.py
5) Use misc.get_inventory_list instead of Image.inventory in
updatemanager.py
Padraig
Shawn Walker wrote:
On Jun 16, 2009, at 3:02 AM, Padraig O'Briain wrote:
On 06/15/09 18:47, Shawn Walker wrote:
On Jun 15, 2009, at 8:50 AM, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-5197-v5/, fixes
5197 gui should not manipulate image objects
src/packagemanager.py:
line 3630: did you really want immediate=True here? When is
update_package_list called? Generally, immediate=True should be
reserved for cases where the user has explicitly requested a refresh,
otherwise the API should "do the right thing."
update_package_list is called from src/gui/modules/installupdate.c
after the user has installed or removed some packages. It is also
called when the user canceled the operation.
Is it safe to remove the immediate=True in this case?
It better be, or there is a bug. All immediate=True does is force the
system to actually contact the publisher's repository to see if there is
new metadata available instead of respecting the refresh_seconds value
that has been set for the publisher.
line 3652: while you should arguably be able to get this information
from a single info() call, for now, this would be faster if you could
call this for all of the packages you need to get the installed
version of instead of for each one.
We get the installed version for each package which was installed or
removed. I believe that the time taken to get the status for each
package individually is in the noise compared to the time to install
or remove the packages. For 9 packages it costs less that .2 seconds.
Ah, ok. That's good to hear then. I was afraid it was taking much
longer than that.
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
