> 4134 pkg operations should report operation sizes
> Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4134
>
> 7736 image plan should provide space requirements for operation
> Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=7736
>
> Last webrev: http://cr.opensolaris.org/~richb/pkg-4134-v3/
From Shawn:
.../src/modules/client/imageplan.py
lines 201-202: replace 'size' with 'dsize'; my fault
line 225: Need _() around "Estimated transfer size"
line 227-228: drop
line 230: s/operation_size/self.get_opstats()[3]/
line 229: Need _() around "Estimated space required"
From Brock:
I'd like to see some test cases for this, ideally an install, update,
and uninstall to double check that the numbers are sane.
From Danek:
imageplan.py:
- line 159: more Pythonic:
return sum((
pp.get_xferstats()[1]
for pp in self.pkg_plans
))
Hopefully I've addressed these concerns now.
New webrev at:
http://cr.opensolaris.org/~richb/pkg-4134-v4/
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
