Shawn Walker wrote:
9002 check_classifications.txt should be adjusted for new post
2008.11 classifications.
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=9002
Last message:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013728.html
Last webrev: http://cr.opensolaris.org/~richb/pkg-9002-v2/
This one needs Dan or Stephen (or whoever) to tell me where the
static file "located somewhere centrally (like a DTD would be)
on opensolaris.org (similar to how DTDs work) or on opensolaris.com
or on sun.com." should be.
When I have that, I can adjust the webrev accordingly and ask for
code review.
Speaking of that ...
Danek and I discussed last week if there was a better option here than
having a centrally located classifications file. After discussion, it
became clear that we didn't really need one at all.
Instead, the client API will be changed to read the classification
information for all packages each time we cache the catalog data and
then cache the resulting package mapping and set of classifications.
In turn, the API will provide a method to get this set of
classifications, so no file will be needed.
Your changes to check_classifications seem fine though, I would just
drop the _resources/ directory and contents from your webrev.
Part of the reason for doing this was so that there would be a single
list of
valid categories/sub-categories available "somewhere", then could be used
by applications such as Source Juicer, to determine whether the
category/sub-category
provided by a new package spec file was valid. As new valid
categories/sub-categories
were determined, then the file would be updated accordingly.
Your proposed change seems to disqualify that.
If this shouldn't be via a "static file located somewhere centrally
(like a DTD would be)"
then how should it be done?
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
