On Fri, Jun 19, 2009 at 08:15:14AM +0100, Padraig O'Briain wrote:
> [email protected] wrote:
>> Okay, I'm not entirely sure I understand, but it's not possible to
>> connect to gconf when you're root?
>
> It is not possible to connect to the user's gconf settings when you are
> running as root.
It would be great if you could explain why this is so. Your explanation
doesn't help me understand what the problem is, aside from being unable
to connect to gconf.
>> Regardless, the launch.py script only checks to see whether the gconf
>> proxy settings are enabled. If the user has set http_proxy in the
>> environment already, we shouldn't overwrite those values. Shouldn't
>> this check to see whether a http_proxy has been defined before deciding
>> whether to get this information from gconf?
>>
>
> I agree with you that launch.py should only access the gconf proxy
> settings if the environment variables are not set. I will respin the
> webrev for that.
Thanks, I'll take a look at that.
> The aim of this fix is to make the behavior when invoking Package
> Manager and Update Manager from the menus or desktop icons the same as
> running it from the terminal.
>
> Making Package Manager and Update Manager react to changes in the user's
> gconf settings will be another bug.
With all due respect, the first entry in 1835 states:
Packagemanager honours http_proxy if run from the command line
(or if http_proxy is set in the login environment), but it's
preferable for desktop applications to use the proxy settings
from the GNOME Network Settings dialog by default, and subscribe
to changes via gconf. This allows the user to make proxy
changes on the fly, without having to resort to the CLI and/or
restart their session.
I took a look at 1835, and the premise here is that packagemanager
should subscribe to gconf for updates. There doesn't appear to be a
thorough explanation in 1835 that you're changing the purpose of the bug
and why. If you still intend to fix the original issue raised in 1835,
which is sounds like you do -- only later, then I'd reccomend you keep
1835 open, and file a different bug for this change that you've got out
for review.
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
