I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-1835-v4/, to only set the
environment variables if they are not already set.
Padraig
Padraig O'Briain wrote:
[email protected] wrote:
On Thu, Jun 18, 2009 at 10:31:09PM +0100, John Rice wrote:
Shawn Walker wrote:
On Jun 18, 2009, at 1:30 PM, [email protected] wrote:
On Thu, Jun 18, 2009 at 01:26:19PM -0500, Shawn Walker wrote:
On Jun 18, 2009, at 1:24 PM, [email protected] wrote:
Packagemanager will need to work correctly in the face of all of
these
configuration choices. I don't think the GNOME configuration should
overrride the environment or the pkg(5) proxy choices. If
neither are
configured, I don't have a problem with consulting the GNOME config,
but
that should be dynamic, i.e. it changes with changes to the
settings.
From what I recall, they are unfortunately constrained by the fact
that
since the packagemanager is running as "root", due to GNOME
behaviour,
they don't have on-demand access to the user's proxy settings.
Hence why
they have to get them before executing the pakagemanager through a
script.
Would you clarify what you mean here? I understand that the user's
environment may not available if we're logged in as root, but I
assumed
that the client was able to subscribe to updates from gconf? Is this
not the case?
That is my understanding, but perhaps they'll be able to share the
details.
Shawn you are correct. We cannot get the user's gconf proxy settings
when running a program as root via gksu. The only thing to do is
grab the user settings in a script and then launch the app with the
appropriate environment setup. This is the case when running the
apps from the menu. If you run the apps from the Gnome Terminal it
sets up the shell environment correctly for the app.
Okay, I'm not entirely sure I understand, but it's not possible to
connect to gconf when you're root?
It is not possible to connect to the user's gconf settings when you are
running as root.
Regardless, the launch.py script only checks to see whether the gconf
proxy settings are enabled. If the user has set http_proxy in the
environment already, we shouldn't overwrite those values. Shouldn't
this check to see whether a http_proxy has been defined before deciding
whether to get this information from gconf?
I agree with you that launch.py should only access the gconf proxy
settings if the environment variables are not set. I will respin the
webrev for that.
The aim of this fix is to make the behavior when invoking Package
Manager and Update Manager from the menus or desktop icons the same as
running it from the terminal.
Making Package Manager and Update Manager react to changes in the user's
gconf settings will be another bug.
Padraig
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
