Danek Duvall wrote:
On Tue, Jun 23, 2009 at 05:41:48PM +0100, Peter Dennis - Sustaining Engineer
wrote:
http://cr.opensolaris.org/~petede/gate/
Perhaps I'm being a bit thick; is the compiler complaining about the
PyObject * to char * conversion? Would the warning go away if we did
return ((void *)PyErr_NoMemory();
instead of the cast-away?
Yes it does.
There are a couple of calls within the pspawn() function which simply
call the PyErr_NoMemory() function without capturing or returning the
value from the call but instead later returning a NULL.
The PyErr_NoMemory() always returns a NULL (as stated by the Python
docs), so it would appear that both conventions are okay but which
is better ?
I do prefer the explicit return of NULL, however I am more than
happy to bow to greater knowledge.
Pete
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
